Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Optimizes adding Linter methods (fixes #9000) #9007

Merged
merged 2 commits into from Jul 26, 2017

Conversation

seandenison26
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)
[X] Other, please explain: Chore, Optimized adding SouceCode object methods to the Linter prototype.

What changes did you make? (Give an overview)
I refactored linter.js to add the SourceCode object methods to the Linter prototype utilizing Object.defineProperties(). This allows any future methods to have more than five arguments as well as makes the new Linter.prototype properties non-enumerable.

Is there anything you'd like reviewers to focus on?

This should have been implemented exactly as requested in issue #9000 and all tests pass. Not sure what should be focussed on other than that.

@eslintbot
Copy link

Thanks for the pull request, @seandenison26! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary must be 72 characters or shorter. Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

1 similar comment
@eslintbot
Copy link

Thanks for the pull request, @seandenison26! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary must be 72 characters or shorter. Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@seandenison26 seandenison26 changed the title Issue9000 Chore: Optimizes adding Linter methods (fixes: 9000) Jul 26, 2017
@eslintbot
Copy link

LGTM

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@platinumazure
Copy link
Member

Note to merger: Change suffix from (fixes: 9000) to (fixes #9000) on merge.

@seandenison26
Copy link
Contributor Author

Note to merger: Change suffix from (fixes: 9000) to (fixes #9000) on merge.

@platinumazure Does that mean I'll need to change the commit message?

@platinumazure
Copy link
Member

platinumazure commented Jul 26, 2017

@seandenison26 Actually your commit messages are fine, but GitHub's online pull request merge interface uses the PR title as the default suggested message, so I wanted to call it out to mergers in case someone was quick. (We do squash commits on merge, so the merge basically generates a new commit message based on the PR title unless we change it while merging.)

If you like, you can edit your PR title to help avoid this. But I was trying to avoid making you do extra work 😄

EDIT: Oh wait, I can change the PR title for you. Hope it's okay that I just went ahead and did that. Thanks!

@platinumazure platinumazure changed the title Chore: Optimizes adding Linter methods (fixes: 9000) Chore: Optimizes adding Linter methods (fixes #9000) Jul 26, 2017
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for contributing!

@not-an-aardvark not-an-aardvark merged commit d0536d6 into eslint:master Jul 26, 2017
@seandenison26 seandenison26 deleted the issue9000 branch July 26, 2017 02:53
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants