Fix: include name of invalid config in validation messages (fixes #8963) #8973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
added
accepted
|
LGTM |
not-an-aardvark
force-pushed
the
config-error-message-info
branch
from
24f7357
to
a2ea57b
Compare
|
LGTM |
Previously, if an ESLint configuration was invalid, the error message would not contain the filename of the offending config. Instead, the error message contained `[object Object]`, which was probably a bug. This commit updates the error message to clearly indicate which config file contains the error.
|
LGTM |
not-an-aardvark
force-pushed
the
config-error-message-info
branch
from
a2ea57b
to
3110318
Compare
gyandeeps
approved these changes
Jul 21, 2017
btmills
approved these changes
Jul 21, 2017
ilyavolodin
approved these changes
Jul 21, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix (#8963)
What changes did you make? (Give an overview)
Previously, if an ESLint configuration was invalid, the error message would not contain the filename of the offending config. Instead, the error message contained
[object Object], which was probably a bug. This commit updates the error message to clearly indicate which config file contains the error.Is there anything you'd like reviewers to focus on?
Nothing in particular