Fix: duplicated error message if a crash occurs (fixes #8964) #8965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
added
accepted
|
LGTM |
not-an-aardvark
force-pushed
the
duplicate-error-messages
branch
from
fc2abb0
to
95ccfde
Compare
|
LGTM |
platinumazure
approved these changes
Jul 19, 2017
ilyavolodin
approved these changes
Jul 19, 2017
| @@ -44,11 +44,10 @@ process.once("uncaughtException", err => { | |||
| if (typeof err.messageTemplate === "string" && err.messageTemplate.length > 0) { | |||
| const template = lodash.template(fs.readFileSync(path.resolve(__dirname, `../messages/${err.messageTemplate}.txt`), "utf-8")); | |||
|
|
|||
| console.log("\nOops! Something went wrong! :("); | |||
| console.log(`\n${template(err.messageData || {})}`); | |||
| console.error("\nOops! Something went wrong! :("); | |||
There was a problem hiding this comment.
I wonder if this might be considered as a breaking change? If somebody wrote an integration that listens for stdout they will get nothing in the case of the crash. But I think that's too much of an edge case.
There was a problem hiding this comment.
I suppose that's possible. Do you think it would be better to separate that into a different commit and schedule it for 5.0?
gyandeeps
approved these changes
Jul 20, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix (#8964)
What changes did you make? (Give an overview)
This updates the uncaught exception handler to avoid printing the error message twice. The error message is included in the stack, so it's not necessary to print the error message and the stack separately.
Is there anything you'd like reviewers to focus on?
Nothing in particular