Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Use output: null to assert that a test case is not autofixed. #8960

Merged
merged 1 commit into from Jul 18, 2017

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Jul 18, 2017

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)
Use output: null to assert that a test case is not autofixed. it is detected by eslint-plugin-eslint-plugin rule prefer-output-null.

Is there anything you'd like reviewers to focus on?

@eslintbot
Copy link

LGTM

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Are we planning to start using the rule in the ESLint codebase?

@aladdin-add
Copy link
Member Author

yes, however I just find a bug on this rule. will fix it and enable it after the plugin's next release.

@platinumazure platinumazure merged commit d09288a into eslint:master Jul 18, 2017
@platinumazure
Copy link
Member

Thanks @aladdin-add for contributing!

@aladdin-add aladdin-add deleted the prefer-output-null branch July 18, 2017 15:24
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants