Chore: make minor improvements to indent internals
#8947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Get rid of an `if` statement whose condition was always true. (With this change, the `indent` rule now has 100% branch coverage.) * Remove the `matchIndentOf` helper in favor of using `setDesiredOffset` with an offset of 0. * Fix outdated or misleading comments * Move some function declarations into methods on the listeners object when possible
not-an-aardvark
added
chore
|
LGTM |
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gyandeeps, @valorkin and @vitorbal to be potential reviewers. |
gyandeeps
approved these changes
Jul 15, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
ifstatement whose condition was always true. (With this change, theindentrule now has 100% branch coverage.)matchIndentOfhelper in favor of usingsetDesiredOffsetwith an offset of 0.Is there anything you'd like reviewers to focus on?
Should I split this into separate PRs? I ended up putting these all in one PR because they would have otherwise conflicted with each other, but I'm fine with splitting them up anyway if that makes it easier to review.