Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix verifyAndFix result property name #8903

Merged
merged 1 commit into from Jul 9, 2017
Merged

Docs: fix verifyAndFix result property name #8903

merged 1 commit into from Jul 9, 2017

Conversation

tinovyatkin
Copy link
Contributor

@tinovyatkin tinovyatkin commented Jul 9, 2017 •
edited

What is the purpose of this pull request? (put an "X" next to item)

[X ] Documentation update

What changes did you make? (Give an overview)

Not sure whether it's a docs error or API error, but verifyAndFix in eslint 4.2 returns fixed code in output property, not in the text.

Is there anything you'd like reviewers to focus on?

@tinovyatkin
Fixed property name
d8be52b 
Not sure whether it's a docs error or API error, but `verifyAndFix` in `eslint 4.2` returns fixed code in `output` property, not in the `text`.
@jsf-clabot
Copy link

jsf-clabot commented Jul 9, 2017 •
edited

CLA assistant check
All committers have signed the CLA.

@eslintbot
Copy link

Thanks for the pull request, @tinovyatkin! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@mention-bot
Copy link

@tinovyatkin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @gyandeeps and @SimenB to be potential reviewers.

@tinovyatkin tinovyatkin changed the title Fixed property name Fix: verifyAndFix result property name Jul 9, 2017
@not-an-aardvark not-an-aardvark changed the title Fix: verifyAndFix result property name Docs: fix verifyAndFix result property name Jul 9, 2017
not-an-aardvark
not-an-aardvark approved these changes Jul 9, 2017
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for contributing!

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly documentation Relates to ESLint's documentation labels Jul 9, 2017
@not-an-aardvark not-an-aardvark merged commit 45f8cd9 into eslint:master Jul 9, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tinovyatkin @jsf-clabot @eslintbot @mention-bot @not-an-aardvark