Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLA link in Contributing docs #8883

Merged
merged 1 commit into from Jul 6, 2017
Merged

Update CLA link in Contributing docs #8883

merged 1 commit into from Jul 6, 2017

Conversation

calvinf
Copy link
Contributor

@calvinf calvinf commented Jul 5, 2017

Replacing old URL redirect with the new JS Foundation URL

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Update a URL in the Markdown contributing doc.

Is there anything you'd like reviewers to focus on?

The URL.

Replacing old URL redirect with the new JS Foundation URL
@jsf-clabot
Copy link

jsf-clabot commented Jul 5, 2017

CLA assistant check
All committers have signed the CLA.

@eslintbot
Copy link

Thanks for the pull request, @calvinf! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks good to me.

Now that the URL for the CLA is correct, would you mind signing it so that we can merge your PR?

@calvinf
Copy link
Contributor Author

calvinf commented Jul 6, 2017

I've signed the CLA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants