Build: Turnoff CI branch build (fixes #8804) #8873
Conversation
gyandeeps
added
build
.travis.yml
Outdated
| # Run npm docs only when its the master branch build | ||
| script: | ||
| - "npm test" | ||
| - 'if [ "$TRAVIS_PULL_REQUEST" = "false" && "$TRAVIS_BRANCH" = "master" ]; then npm run docs; fi' |
There was a problem hiding this comment.
I'd add $node_js check to not run docs on each node_js version.
Same could be done for linting, btw.
script:
- npm test
- if [ "$TRAVIS_PULL_REQUEST" = "false" && "$TRAVIS_BRANCH" = "master" && "$node_js" = "8" ] ...There was a problem hiding this comment.
very cool. I will add this and also make coverall to run only for node 8 as well.
|
LGTM |
.travis.yml
Outdated
| # Run npm docs only when its the master branch build and node 8 | ||
| script: | ||
| - "npm test" | ||
| - 'if [[ "$TRAVIS_PULL_REQUEST" = "false" && "$TRAVIS_BRANCH" = "master" && "$node_js" = "8" ]]; then npm run docs; fi' |
There was a problem hiding this comment.
What's the point of running npm run docs on master? I had assumed that we were running npm run docs to make sure the docs can be built without errors, but if we're waiting until the docs are on master then it would already be too late if they've broken.
There was a problem hiding this comment.
Agree. Our jsdoc generation is not even documented anywhere. To tell the truth, I've been working on ESLint since week 3, and I have never generated or even looked at our jsDoc output, so I'm not sure we should be re-running jsdoc generation on every build.
There was a problem hiding this comment.
Are you guys suggesting to actually remove the generation of docs from all the build?
There was a problem hiding this comment.
I wouldn't mind that -- I've never personally used the autogenerated docs.
There was a problem hiding this comment.
@gyandeeps Yes, I don't know of anyone consuming them.
gyandeeps
added
accepted
|
LGTM |
.travis.yml
Outdated
| @@ -14,7 +14,6 @@ branches: | |||
| # Run npm docs only when its the master branch build and node 8 | |||
|
LGTM |
eslint-deprecated
bot
added
the
archived due to age
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ x ] Other, please explain:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?