Fix: --quiet no longer fixes warnings (fixes #8675) #8858
Conversation
|
LGTM |
|
@platinumazure, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jrajav, @not-an-aardvark and @mysticatea to be potential reviewers. |
platinumazure
added
accepted
|
Hmm... Possible improvement might be to expose the fix predicate as |
There was a problem hiding this comment.
LGTM, thanks!
Hmm... Possible improvement might be to expose the fix predicate as
CLIEngine.fixErrorsOnlyPredicateor similar so CLIEngine users can easily emulate--quieton the CLI.
Meh, I think the fix predicate is fairly trivial, so I would mildly prefer not including that since it's simple for API users to create it on their own.
lib/cli.js
Outdated
| * autofixed), false otherwise. | ||
| */ | ||
| function quietFixPredicate(lintResult) { | ||
| return Boolean(lintResult && lintResult.severity === 2); |
There was a problem hiding this comment.
Why can't this be return lintResult.severity === 2? Is lintResult ever null?
There was a problem hiding this comment.
It probably should never be null. Normally I favor defensive coding to be safe; but since this could be a tight path (running this function on every lint message), I am happy to shave off those cycles. I'll update tonight (US).
|
Adding "do not merge" so I can make a suggested change. |
|
LGTM |
|
@not-an-aardvark Updated per your suggestion, thanks! |
eslint-deprecated
bot
added
the
archived due to age
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
See #8675.
What changes did you make? (Give an overview)
When
--quietis specified by user, lib/cli.js will pass a fix predicate function to CLIEngine so that only errors are fixed. That way, warnings (which aren't even reported in--quietmode and about which they might know nothing) are not fixed and users are thus no longer surprised by extra changes being made to ESLint.Is there anything you'd like reviewers to focus on?
Nothing in particular.