Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: enable rule for-direction #8853

Merged
merged 1 commit into from Jul 2, 2017
Merged

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Jul 1, 2017

What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
enable rule for-direction

What changes did you make? (Give an overview)
the rule for-direction enforce “for” loop update clause moving the counter in the right direction. Typically, violating this rule is a bug.

Is there anything you'd like reviewers to focus on?
Ideally it can be added into eslint:recommended, so I'm not sure it is proper to enable it now.

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@aladdin-add, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @not-an-aardvark and @alberto to be potential reviewers.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'm definitely 👍 to dogfooding our own rules where practical.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants