Docs: Clarify arrow function parens in no-extra-parens (fixes #8741) #8822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platinumazure
added
accepted
|
LGTM |
|
@platinumazure, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pedrottimark, @michaelficarra and @jrvidal to be potential reviewers. |
not-an-aardvark
approved these changes
Jun 28, 2017
| @@ -9,6 +9,8 @@ This rule always ignores extra parentheses around the following: | |||
| * RegExp literals such as `(/abc/).test(var)` to avoid conflicts with the [wrap-regex](wrap-regex.md) rule | |||
| * immediately-invoked function expressions (also known as IIFEs) such as `var x = (function () {})();` and `((function foo() {return 1;})())` to avoid conflicts with the [wrap-iife](wrap-iife.md) rule | |||
|
|
|||
| In addition, this rule ignores parentheses around arrow function arguments to avoid conflicts with the [arrow-parens](arrow-parens.md) rule. | |||
There was a problem hiding this comment.
Should this be part of the bulleted list right above it, rather than a separate paragraph?
There was a problem hiding this comment.
Hmm... The only reason I did that was because arrow function arguments are not an expression with malleable precedence, unlike RegExp literals and IIFEs, so it felt like apples/oranges to me. But I don't have a strong preference either way.
There was a problem hiding this comment.
Neither do I, so I'm satisfied by your explanation. 👍
This was referenced Jul 9, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
See #8741.
What changes did you make? (Give an overview)
Added note about arrow function parens being covered by
arrow-parensinstead ofno-extra-parens. Also addedarrow-parensto Related Rules section.Is there anything you'd like reviewers to focus on?
Not really.