Fix: don't require a third argument in linter.verifyAndFix (fixes #8805) #8809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `linter.verifyAndFix` would crash if no third argument was provided, because some debugging lines assumed that the argument always existed. This updates the method to make the third argument optional.
not-an-aardvark
added
accepted
|
LGTM |
platinumazure
approved these changes
Jun 26, 2017
gyandeeps
approved these changes
Jun 26, 2017
|
I don't think so, it's very minor. We can include it if we do a patch release to fix another issue though. |
kaicataldo
approved these changes
Jun 27, 2017
not-an-aardvark
pushed a commit
that referenced
this pull request
Jun 29, 2017
* New: Allow passing a function as `fix` option (fixes #8039) * Pass fix in options, instead of separate arg * Simplify conditional logic * Return source code if shouldFix is false This way, the code that uses this doesn’t need to necessarily check the value of `fixed`. * Clarify that fixesWereApplied is always true here If we’ve gotten to this point, at least one fix will have been applied. * Add a test to ensure that fix functions are pure Meaning, that they cannot access the `this` value of SourceCodeFixer. * Add test with conditional shouldFix This is to verify that the problem can be used to return true or false conditionally, and that eslint will only apply fixes when true is returned. * Account for options not being provided This is to account for #8809
This was referenced Jul 9, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix (#8805)
What changes did you make? (Give an overview)
Previously,
linter.verifyAndFixwould crash if no third argument was provided, because some debugging lines assumed that the argument always existed. This updates the method to make the third argument optional.Is there anything you'd like reviewers to focus on?
Nothing in particular