New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: fix parenthesized CallExpression indentation (fixes #8790) #8802
Conversation
This fixes a bug in the `indent` rule where the arguments of a call expression were aligned offset the last token of the callee, even when the callee was parenthesized. Instead, the rule should offset from the closing paren in those cases.
LGTM |
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vitorbal, @gyandeeps and @valorkin to be potential reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add invalid tests for the incorrect behavior? As it is, I'm not 100% sure what the rule was enforcing earlier. (Please dismiss if invalid tests are already present and I'm just not seeing them.)
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these! I hope these will be useful regression tests. LGTM, thanks!
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix (#8790)
What changes did you make? (Give an overview)
This fixes a bug in the
indent
rule where the arguments of a call expression were aligned offset the last token of the callee, even when the callee was parenthesized. Instead, the rule should offset from the closing paren in those cases.Is there anything you'd like reviewers to focus on?
Nothing in particular