Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ensure configs from a plugin are cached separately (fixes #8792) #8798

Merged
merged 3 commits into from
Jun 26, 2017

Commits on Jun 24, 2017

  1. Fix: ensure configs from a plugin are cached separately (fixes #8792)

    Config files are cached by file path to avoid needing to load the same config file twice. However, configs provided by plugins all have the same file path (the index file of the plugin). This created a bug when loading multiple configs for the same plugin where only the highest-precedence config from that plugin would be loaded. All other configs from that plugin would be considered identical by the cache, so they would all end up getting pulled from the cache as the same config.
    
    This commit updates the caching logic to use the config full name as a cache index. This is still the file path when resolving a config from the filesystem, but it is the unique plugin config identifier (e.g. 'plugin:foo/node-config') when resolving a plugin config.
    not-an-aardvark committed Jun 24, 2017
    Configuration menu
    Copy the full SHA
    79f2d3f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2017

  1. Configuration menu
    Copy the full SHA
    958a2c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2017

  1. Configuration menu
    Copy the full SHA
    4259f30 View commit details
    Browse the repository at this point in the history