Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: enable computed-property-spacing on ESLint codebase #8760

Merged
merged 1 commit into from Jun 18, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cli-engine.js
Expand Up @@ -318,7 +318,7 @@ function getCacheFile(cacheFile, cwd) {
cacheFile = path.normalize(cacheFile);

const resolvedCacheFile = path.resolve(cwd, cacheFile);
const looksLikeADirectory = cacheFile[cacheFile.length - 1 ] === path.sep;
const looksLikeADirectory = cacheFile[cacheFile.length - 1] === path.sep;

/**
* return the name for the cache file in case the provided parameter is a directory
Expand Down
2 changes: 1 addition & 1 deletion lib/code-path-analysis/code-path-state.js
Expand Up @@ -240,7 +240,7 @@ class CodePathState {
this.breakContext = null;

this.currentSegments = [];
this.initialSegment = this.forkContext.head[ 0 ];
this.initialSegment = this.forkContext.head[0];

// returnedSegments and thrownSegments push elements into finalSegments also.
const final = this.finalSegments = [];
Expand Down
2 changes: 1 addition & 1 deletion lib/config.js
Expand Up @@ -198,7 +198,7 @@ class Config {
this.useEslintrc = (options.useEslintrc !== false);

this.env = (options.envs || []).reduce((envs, name) => {
envs[ name ] = true;
envs[name] = true;
return envs;
}, {});

Expand Down
1 change: 1 addition & 0 deletions packages/eslint-config-eslint/default.yml
Expand Up @@ -16,6 +16,7 @@ rules:
comma-dangle: "error"
comma-spacing: "error"
comma-style: ["error", "last"]
computed-property-spacing: "error"
consistent-return: "error"
curly: ["error", "all"]
default-case: "error"
Expand Down