Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: fix multiline binary operator/parentheses indentation #8719

Merged
merged 1 commit into from Jun 15, 2017
Merged

Update: fix multiline binary operator/parentheses indentation #8719

merged 1 commit into from Jun 15, 2017

Commits on Jun 13, 2017

  1. Update: fix multiline binary operator/parentheses indentation 

    Fixes #8666, fixes #8717, fixes #8710

Previously, the logic for indenting multiline parenthesized expressions assumed that the indentation of every token in the expression other than the first was dependent on the first token. However, this assumption is not always correct. This led to bugs with multiline parenthesized expressions (#8710). Additionally, the BinaryExpression listener attempted to account for this assumption by always linking its tokens' indentation to the first token's indentation, even when it didn't make sense to do so. This led to other bugs (#8666, #8717). This commit updates the parenthesis logic to avoid making that assumption and check the indentation of all the tokens properly.
    @not-an-aardvark
    not-an-aardvark committed Jun 13, 2017
    Configuration menu
    Copy the full SHA
    1a171dc View commit details
    Browse the repository at this point in the history