New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: upgrade deps. #8684
Chore: upgrade deps. #8684
Conversation
LGTM |
@aladdin-add, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alberto, @nzakas and @mysticatea to be potential reviewers. |
As mentioned in Greenkeeper issue, we have to have a good reason to update dependancies. We don't update them whenever the new version comes out. I'm not sure we need to update them right now, unless you know of a good reason to do so. |
@ilyavolodin What's the disadvantage of upgrading dependencies? By the way, this was also discussed in #8304. |
At least for packages we maintain ourselves (espree), I think it makes some sense to offer latest and greatest if we can. Otherwise, I can see both sides. |
agree to this. but what is “a good reason”. since we have a very good test coverage, (maybe) it is safe to upgrade to latest. |
I support periodic updates like these. I think there is no harm doing this periodically. |
I would also prefer that the dependencies are updated regularly, but just my two cents |
@ilyavolodin It looks like three team members are in favor of this PR. Are you okay with it being merged? |
I'm fine with merging this one. Updating deps once in a while is perfectly fine. I just don't really want to update as soon as a new version of dependency comes out. |
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
upgrade deps to latest version.
Is there anything you'd like reviewers to focus on?