Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: upgrade deps. #8684

Merged
merged 1 commit into from Jun 10, 2017
Merged

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Jun 3, 2017

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)
upgrade deps to latest version.

Is there anything you'd like reviewers to focus on?

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@aladdin-add, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alberto, @nzakas and @mysticatea to be potential reviewers.

@ilyavolodin
Copy link
Member

As mentioned in Greenkeeper issue, we have to have a good reason to update dependancies. We don't update them whenever the new version comes out. I'm not sure we need to update them right now, unless you know of a good reason to do so.

@not-an-aardvark
Copy link
Member

@ilyavolodin What's the disadvantage of upgrading dependencies?

By the way, this was also discussed in #8304.

@platinumazure
Copy link
Member

At least for packages we maintain ourselves (espree), I think it makes some sense to offer latest and greatest if we can. Otherwise, I can see both sides.

@not-an-aardvark not-an-aardvark added chore This change is not user-facing evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jun 4, 2017
@aladdin-add
Copy link
Member Author

aladdin-add commented Jun 4, 2017

As mentioned in Greenkeeper issue, we have to have a good reason to update dependancies. We don't update them whenever the new version comes out.

agree to this. but what is “a good reason”. since we have a very good test coverage, (maybe) it is safe to upgrade to latest.

@gyandeeps
Copy link
Member

I support periodic updates like these. I think there is no harm doing this periodically.

@corbinu
Copy link
Contributor

corbinu commented Jun 5, 2017

I would also prefer that the dependencies are updated regularly, but just my two cents

@not-an-aardvark
Copy link
Member

not-an-aardvark commented Jun 10, 2017

@ilyavolodin It looks like three team members are in favor of this PR. Are you okay with it being merged?

@ilyavolodin
Copy link
Member

I'm fine with merging this one. Updating deps once in a while is perfectly fine. I just don't really want to update as soon as a new version of dependency comes out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants