New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support an "eslint" property for package.json configuration #8589
Conversation
Thanks for the pull request, @milesj! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
@milesj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @mysticatea and @not-an-aardvark to be potential reviewers. |
LGTM |
It looks to be brought up enough to be reconsidered. There's nothing inherently wrong in support multiple options. |
My take: Setting up lint configuration (as least the basic structure) only has to happen once, so with typing |
I like the idea of standardizing configuration in the JS ecosystem, but I agree that it's confusing to support multiple options. |
If we're adding an |
Thanks for your interest in improving ESLint. Unfortunately, it looks like this issue didn't get enough support from the team and so I'm closing it. While we wish we'd be able to accommodate everyone's requests, we do need to prioritize. We've found that issues failing to reach consensus after a long time tend to never do it, and as such, we close those issues. This doesn't mean the idea isn't interesting, just that it's not something the team can commit to. |
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Support
eslint
alongsideeslintConfig
as a configuration property in package.json.A large majority of build tools that allow configuration through package.json simply use the project name as the property name, like
babel
,ava
,jest
, instead ofbabelConfig
, etc.This PR simply adds a bit of consistency with other build tools, and removes any confusion when
eslint
is used (instead ofeslintConfig
).Is there anything you'd like reviewers to focus on?
Not really. Consumer choice is always nice.