Docs: clarify that no-unsafe-negation is in eslint:recommended #8371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mysticatea and @kaicataldo to be potential reviewers. |
|
LGTM |
no-unsafe-negation was added to eslint:recommended in #7467, but this is not reflected in the docs. This commit updates the docs to indicate that no-unsafe-negation is in eslint:recommended. Similarly, no-negated-in-lhs and no-native-reassign have not been in eslint:recommended since #7467, so this commit updates the docs to indicate that. (refs #8370)
not-an-aardvark
force-pushed
the
fix-no-unsafe-negation-recommended
branch
from
488fd6a
to
f295f4a
Compare
|
LGTM |
platinumazure
approved these changes
Mar 31, 2017
vitorbal
approved these changes
Mar 31, 2017
gyandeeps
approved these changes
Mar 31, 2017
kaicataldo
approved these changes
Mar 31, 2017
This was referenced Mar 31, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
What changes did you make? (Give an overview)
no-unsafe-negation was added to eslint:recommended in #7467, but this is not reflected in the docs. This commit updates the docs to indicate that no-unsafe-negation is in eslint:recommended.
Similarly, no-negated-in-lhs and no-native-reassign have not been in eslint:recommended since #7467, so this commit updates the docs to indicate that.
(refs #8370)
Is there anything you'd like reviewers to focus on?
Nothing in particular