Fix: no-extra-parens false positive with functions in default exports #8359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
added
accepted
|
LGTM |
platinumazure
approved these changes
Mar 29, 2017
|
I noticed a few related cases where the check still fails, so I'll update this PR in a few minutes. |
not-an-aardvark
force-pushed
the
no-extra-parens-export-defaults
branch
from
18aef8b
to
a9a8102
Compare
|
LGTM |
not-an-aardvark
commented
Mar 29, 2017
| @@ -545,8 +566,6 @@ ruleTester.run("no-extra-parens", rule, { | |||
| invalid("bar((function(){}).foo(), 0);", "bar(function(){}.foo(), 0);", "FunctionExpression"), | |||
| invalid("bar[(function(){}).foo()];", "bar[function(){}.foo()];", "FunctionExpression"), | |||
| invalid("var bar = (function(){}).foo();", "var bar = function(){}.foo();", "FunctionExpression"), | |||
| invalid("((function(){}).foo.bar)();", "(function(){}.foo.bar)();", "FunctionExpression", null, { options: ["functions"] }), | |||
| invalid("((function(){}).foo)();", "(function(){}.foo)();", "FunctionExpression", null, { options: ["functions"] }), | |||
There was a problem hiding this comment.
These two cases were moved into "valid" because the functions option is enabled and the parens around the function are necessary (it's the parens around the call expression that are unnecessary). This is consistent with cases like this, where the MemberExpression parens are reported and removed instead of the FunctionExpression parens.
This commit fixes an issue where no-extra-parens would incorrectly report parenthesized functions and classes in `export default` declarations, object literals at the beginning of expression statements.
not-an-aardvark
force-pushed
the
no-extra-parens-export-defaults
branch
from
a9a8102
to
8147765
Compare
|
LGTM |
|
If people have time, I'd appreciate another review on this -- it has changed significantly since the last review. |
platinumazure
approved these changes
Mar 31, 2017
btmills
approved these changes
Mar 31, 2017
This was referenced Mar 31, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
Please show your full configuration:
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
No error should be reported, because removing the parentheses would be a syntax error.
What actually happened? Please include the actual, raw output from ESLint.
Errors were reported for both lines.
What changes did you make? (Give an overview)
This commit fixes an issue where no-extra-parens would incorrectly report parenthesized functions and classes in
export defaultdeclarations. Previously, our logic for checking whether a token was allowed at the beginning of an expression (e.g.functionto distinguish between function declarations and function expressions) was incomplete, so this commit refactors that logic.Is there anything you'd like reviewers to focus on?
Nothing in particular