Fix: no-implicit-coercion invalid autofix with consecutive identifiers

[not-an-aardvark]

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

Tell us about your environment

• ESLint Version: master
• Node Version: 7.7.4
• npm Version: 4.1.2

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

rules:
  no-implicit-coercion: error

What did you do? Please include the actual source code causing the issue.

typeof+foo

What did you expect to happen?

I expected the code to get autofixed to

typeof Number(foo)

What actually happened? Please include the actual, raw output from ESLint.

The code was autofixed to

typeofNumber(foo)

What changes did you make? (Give an overview)

Previously, the no-implicit-coercion rule would convert code like typeof+foo to typeofNumber(foo), combining the typeof keyword with the following identifier and changing the semantics. This commit updates the no-implicit-coercion autofixer to prevent that from happening.

Is there anything you'd like reviewers to focus on?

Nothing in particular

[mention-bot]

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @TheSavior, @mysticatea and @kaicataldo to be potential reviewers.

[eslintbot]

LGTM

[ilyavolodin]

Is typeof+foo even a valid syntax? What is supposed to do?

[platinumazure]

@ilyavolodin It's parsed as typeof +foo. Just two unary operators applied in succession.

I would hope nobody writes code like that, but we should be able to accept all sorts of crazy syntax while linting.