Fix: no-useless-computed-key invalid autofix for getters and setters #8335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
added
accepted
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @BYK, @mysticatea and @kaicataldo to be potential reviewers. |
|
LGTM |
ilyavolodin
approved these changes
Mar 26, 2017
Previously, the no-useless-computed-key autofixer could sometimes place a key next to `get`, `set`, or `async` identifier in a property, causing the identifier and the key to combine and become a new identifier. This commit updates the autofixer to insert a space whenever that would happen to prevent the identifiers from combining.
not-an-aardvark
force-pushed
the
no-useless-computed-key-identifier-joining
branch
from
e30d1b2
to
c79463a
Compare
|
LGTM |
platinumazure
approved these changes
Mar 27, 2017
| // Insert a space before the key to avoid changing identifiers, e.g. ({ get[2]() {} }) to ({ get2() {} }) | ||
| const needsSpaceBeforeKey = tokenBeforeLeftBracket.range[1] === leftSquareBracket.range[0] && | ||
| esUtils.code.isIdentifierPartES6(tokenBeforeLeftBracket.value.slice(-1).charCodeAt(0)) && | ||
| esUtils.code.isIdentifierPartES6(key.raw.charCodeAt(0)); |
There was a problem hiding this comment.
I think this logic might need to be extracted to ast-utils or similar (I've seen this in two PRs today).
There was a problem hiding this comment.
That's probably a good idea. I'll make a separate PR for it though.
gyandeeps
approved these changes
Mar 27, 2017
This was referenced Mar 31, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
I expected the code to be autofixed to
What actually happened? Please include the actual, raw output from ESLint.
The code was autofixed to
What changes did you make? (Give an overview)
Previously, the no-useless-computed-key autofixer could sometimes place a key next to
get,set, orasyncidentifier in a property, causing the identifier and the key to combine and become a new identifier. This commit updates the autofixer to insert a space whenever that would happen to prevent the identifiers from combining.Is there anything you'd like reviewers to focus on?
Nothing in particular