Fix: dot-notation autofix produces errors on parenthesized computed keys #8330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
added
accepted
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vitorbal, @gyandeeps and @goatslacker to be potential reviewers. |
|
LGTM |
This commit updates the dot-notation autofixer logic to ensure that parenthesized computed keys are handled correctly. Previously, the rule didn't account for the possibility that a computed key might be parenthesized, so it ended up using the parens instead of the square brackets for the fix range.
not-an-aardvark
force-pushed
the
dot-notation-computed-parens
branch
from
314e035
to
db8735c
Compare
|
LGTM |
ilyavolodin
approved these changes
Mar 26, 2017
gyandeeps
approved these changes
Mar 27, 2017
platinumazure
approved these changes
Mar 27, 2017
|
|
||
| if (textBeforeProperty.trim() || textAfterProperty.trim()) { | ||
| if (sourceCode.getFirstTokenBetween(leftBracket, rightBracket, { includeComments: true, filter: astUtils.isCommentToken })) { |
There was a problem hiding this comment.
Is includeComments: true necessary here?
There was a problem hiding this comment.
Yes, the idea is to find comments. (If includeComments: true wasn't used, then the iterator would only run on the non-comment tokens, and the filter would return false for all of them.)
There was a problem hiding this comment.
Oh hell, I misread the filter parameter there. Yes, obviously we need that parameter. Thanks for clarifying.
This was referenced Mar 31, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
Please show your full configuration:
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
I expected eslint to autofix the code to
What actually happened? Please include the actual, raw output from ESLint.
eslint autofixed the code to invalid syntax:
What changes did you make? (Give an overview)
This commit updates the dot-notation autofixer logic to ensure that parenthesized computed keys are handled correctly. Previously, the rule didn't account for the possibility that a computed key might be parenthesized, so it ended up using the parens instead of the square brackets for the fix range.
Is there anything you'd like reviewers to focus on?
Nothing in particular