Chore: update sinon calls to deprecated API. #8310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@alberto, thanks for your PR! By analyzing the history of the files in this pull request, we identified @IanVS, @not-an-aardvark and @mysticatea to be potential reviewers. |
platinumazure
requested changes
Mar 22, 2017
tests/lib/util/path-util.js
Outdated
| @@ -74,7 +74,7 @@ describe("pathUtil", () => { | |||
| const filePath = "file/path.js"; | |||
| const basePath = "/absolute/file"; | |||
|
|
|||
| sinon.stub(process, "cwd", () => "/absolute/"); | |||
| sinon.stub(process, "cwd").callsFake(() => "/absolute/"); | |||
There was a problem hiding this comment.
It'd be more idiomatic to use sinon.stub(process, "CWD").returns("/absolute/") here.
alberto
force-pushed
the
update-sinon-calls
branch
from
83fe018
to
ada1d5f
Compare
|
LGTM |
gyandeeps
approved these changes
Mar 22, 2017
vitorbal
approved these changes
Mar 23, 2017
platinumazure
approved these changes
Mar 23, 2017
This was referenced Mar 31, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
What changes did you make? (Give an overview)
sinon started complaining noisily about using a deprecated call:
This PR removes the warning.
Is there anything you'd like reviewers to focus on?
No.