Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Incorrect error location properties in tests #8307

Merged
merged 1 commit into from Mar 22, 2017

Conversation

alberto
Copy link
Member

@alberto alberto commented Mar 22, 2017

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

What changes did you make? (Give an overview)
Put the line and column location of the errors inside the error object, where they belong.

Is there anything you'd like reviewers to focus on?
No.

@mention-bot
Copy link

@alberto, thanks for your PR! By analyzing the history of the files in this pull request, we identified @glenjamin, @nzakas and @gyandeeps to be potential reviewers.

@eslintbot
Copy link

LGTM

@alberto alberto added the chore This change is not user-facing label Mar 22, 2017
@not-an-aardvark
Copy link
Member

The build is failing because there are trailing spaces in tests/lib/rules/no-unexpected-multiline.js.

@alberto
Copy link
Member Author

alberto commented Mar 22, 2017

Oopsie

@eslintbot
Copy link

LGTM

@not-an-aardvark not-an-aardvark merged commit 8733e6a into master Mar 22, 2017
@vitorbal vitorbal deleted the test-locations branch March 22, 2017 08:38
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants