Chore: use precalculated counts in codeframe formatter #8296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
gyandeeps
approved these changes
Mar 20, 2017
vitorbal
commented
Mar 20, 2017
|
|
||
| formatter(code); | ||
|
|
||
| assert.equal(chalkStub.yellow.bold.callCount, 0); | ||
| assert.equal(chalkStub.red.bold.callCount, 1); | ||
| }); | ||
|
|
||
| it("should return bold yellow summary when there are only warnings", () => { |
There was a problem hiding this comment.
The diff is kind of misleading here. Just to clarify, this was not removed, it was moved up to a separate describe section above.
|
Hmm, I'm not sure I understand why |
|
I think we should be able to ignore it. Since branch build completed on both appveyor as well as travis. |
platinumazure
approved these changes
Mar 20, 2017
not-an-aardvark
approved these changes
Mar 20, 2017
ilyavolodin
approved these changes
Mar 20, 2017
This was referenced Mar 31, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Chore. See below.
What changes did you make? (Give an overview)
Updated the codeframe formatter to use the precalculated error and warning counts, just like it was done in #8251.
Is there anything you'd like reviewers to focus on?
I think not!