Chore: improve test coverage for node-event-generator #8287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previonsly, there were insufficient tests for alphabetical selector sorting in the case where selectors had equal specificity. There were also no tests for emitting a selector whose type could not be inferred while exiting the AST.
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mysticatea to be a potential reviewer. |
|
LGTM |
gyandeeps
approved these changes
Mar 18, 2017
This was referenced Mar 31, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
Previously, there were insufficient tests for alphabetical selector sorting in the case where selectors had equal specificity. There were also no tests for emitting a selector whose type could not be inferred while exiting the AST.
Is there anything you'd like reviewers to focus on?
Nothing in particular