Fix: no-param-reassign false positive on destructuring (fixes #8279) #8281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates no-param-reassign to stop traversing up the AST if it encounters a Property node where the variable reference is part of the key.
not-an-aardvark
added
accepted
|
LGTM |
gyandeeps
approved these changes
Mar 18, 2017
mysticatea
suggested changes
Mar 18, 2017
tests/lib/rules/no-param-reassign.js
Outdated
| code: "function foo(bar) { ({foo: bar.a} = {}); }", | ||
| parserOptions: { ecmaVersion: 6 }, | ||
| options: [{ props: true }], | ||
| errors: [{ message: "Assignment to property of function parameter 'bar'." }] | ||
| } |
There was a problem hiding this comment.
I'd like to see the test function foo(a) { ({a} = obj); } as invalid.
|
LGTM |
mysticatea
approved these changes
Mar 18, 2017
This was referenced Mar 31, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix (#8279)
What changes did you make? (Give an overview)
This updates no-param-reassign to stop traversing up the AST if it encounters a Property node where the variable reference is part of the key.
This fix keeps the general strategy of the rule in place. However, while I haven't investigated it in depth, the rule strategy seems a bit fragile -- it reports any reference to a variable on the left side of an assignment, excluding some specific cases such as computed properties. It's possible there are more cases like this that cause false positives -- if so, we might want to rethink how this rule is implemented.
Is there anything you'd like reviewers to focus on?
Nothing in particular