Chore: Ensuring eslint:recommended rules are sorted. #8106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renaming to conf/eslint-recommended.js for parity with conf/eslint-all.js and ensuring references are fixed as well.
|
LGTM |
|
@platinumazure, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @gyandeeps and @mysticatea to be potential reviewers. |
gyandeeps
approved these changes
Feb 20, 2017
ilyavolodin
approved these changes
Feb 20, 2017
This was referenced Feb 20, 2017
pantosha
pushed a commit
to pantosha/eslint
that referenced
this pull request
Feb 21, 2017
* Chore: Ensuring eslint:recommended rules are sorted. Also renaming to conf/eslint-recommended.js for parity with conf/eslint-all.js and ensuring references are fixed as well. * Chore: Fix Makefile message for missing eslint:recommended configuration
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also renaming to conf/eslint-recommended.js for parity with conf/eslint-all.js and ensuring references are fixed as well.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Chore: See commit summary and body above.
What changes did you make? (Give an overview)
Goal was to ensure that our eslint:recommended list is sorted alphabetically. In order to ensure that, I've converted the file to a .js, added some ESLint comments to enable sort-keys on that file (and also actually sorted the rules).
Since I needed to go through all references and fix those (require statements had to use the file extension, etc.), I figured I might as well rename the file to
conf/eslint-recommended.jsfor greater clarity. This will allow new contributors to more easily find theIs there anything you'd like reviewers to focus on?
Nothing in particular.