Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: use updated token iterator methods #8103

Merged
merged 1 commit into from Feb 19, 2017
Merged

Conversation

kaicataldo
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Chore

What changes did you make? (Give an overview)
Updating instances of:

  • sourceCode.getTokenOrCommentBefore(node) -> sourceCode.getTokenBefore(node, { includeComments: true })
  • sourceCode.getTokenOrCommentAfter(node) -> sourceCode.getTokenAfter(node, { includeComments: true })

Is there anything you'd like reviewers to focus on?
Nothing in particular.

@mention-bot
Copy link

@kaicataldo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gyandeeps, @vitorbal and @mysticatea to be potential reviewers.

@eslintbot
Copy link

LGTM

@kaicataldo kaicataldo added chore This change is not user-facing evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Feb 19, 2017
@kaicataldo kaicataldo removed the evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion label Feb 19, 2017
@alberto alberto merged commit f62a724 into master Feb 19, 2017
pantosha pushed a commit to pantosha/eslint that referenced this pull request Feb 21, 2017
@kaicataldo kaicataldo deleted the update-token-methods branch May 12, 2017 20:18
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants