Update: Improve error reporting when extending missing config (fixes … #8100
Conversation
|
Thanks for the pull request, @alberto! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
|
@alberto, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @mysticatea and @not-an-aardvark to be potential reviewers. |
alberto
added
accepted
|
LGTM |
messages/extend-config-missing.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ESLint couldn't find the config "<%- configName %>" to extend from. Please, check the name of the config is correct. | |||
There was a problem hiding this comment.
Nitpick about the wording here: Please, check the name of the config is correct. -> Please check that the name of the config is correct.
messages/extend-config-missing.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ESLint couldn't find the config "<%- configName %>" to extend from. Please, check the name of the config is correct. | |||
|
|
|||
| If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team. | |||
There was a problem hiding this comment.
Nitpick: Not a big fan of "If you still can't figure out the problem" - sounds a bit accusatory. Alternative suggestion: "If you are still having difficulties after checking the above, please stop by https://gitter.im/eslint/eslint to chat with the team."
messages/extend-config-missing.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ESLint couldn't find the config "<%- configName %>" to extend from. Please, check the name of the config is correct. | |||
|
|
|||
| If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team. | |||
There was a problem hiding this comment.
I know we have other error messages that also link to the chatroom, but have we considered using something other than a hardcoded URL? If we ever switch from Gitter to something else, anyone with an old ESLint version will get directed to an inactive support link. I wonder if we should link people to eslint.org/chatroom or something, and then have that URL redirect to Gitter. Then we could change the redirect if we end up moving away from Gitter in the future.
There was a problem hiding this comment.
I can do this as a different PR to avoid mixing concerns.
|
LGTM |
eslint-deprecated
bot
added
the
archived due to age
…#6115)
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[X] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Improve error message when a base config is not found.
Is there anything you'd like reviewers to focus on?
No.