Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect source code test text #8096

Merged
merged 1 commit into from Feb 18, 2017
Merged

Incorrect source code test text #8096

merged 1 commit into from Feb 18, 2017

Conversation

jfo84
Copy link
Contributor

@jfo84 jfo84 commented Feb 17, 2017

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

I changed the description for two tests covering source-code.js

Is there anything you'd like reviewers to focus on?

Not really. In trying to figure out how to write a fixer for prefer-destructuring, I discovered this small issue

@jsf-clabot
Copy link

jsf-clabot commented Feb 17, 2017

CLA assistant check
All committers have signed the CLA.

@eslintbot
Copy link

Thanks for the pull request, @jfo84! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@mention-bot
Copy link

@jfo84, thanks for your PR! By analyzing the history of the files in this pull request, we identified @not-an-aardvark, @nzakas and @mysticatea to be potential reviewers.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing! We can add a "Chore:" prefix on merge.

@jfo84
Copy link
Contributor Author

jfo84 commented Feb 18, 2017

@platinumazure sounds good!

@alberto alberto merged commit ff066dc into eslint:master Feb 18, 2017
pantosha pushed a commit to pantosha/eslint that referenced this pull request Feb 21, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants