Upgrade: mock-fs #8070
Merged
Upgrade: mock-fs #8070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
added
accepted
|
@mysticatea, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @alberto and @gyandeeps to be potential reviewers. |
|
LGTM |
alberto
approved these changes
Feb 13, 2017
vitorbal
approved these changes
Feb 13, 2017
ilyavolodin
approved these changes
Feb 13, 2017
platinumazure
approved these changes
Feb 13, 2017
There was a problem hiding this comment.
Confirming that this does fix my issue. Thanks for looking into this @mysticatea!
This was referenced Feb 20, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Other, please explain: fixes #7799
What changes did you make? (Give an overview)
This PR fixes a failing test about absolute path on Windows.
I'm not sure why, but I confirmed #7799 is fixed if I upgrade
mock-fs.Is there anything you'd like reviewers to focus on?
If anyone can explain this mechanism, I'm glad.