Fix: no-extra-boolean-cast incorrect Boolean() autofixing (fixes #7977) #8037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwilsson, thanks for your PR! By analyzing the history of the files in this pull request, we identified @btmills, @Met48 and @not-an-aardvark to be potential reviewers. |
|
LGTM |
not-an-aardvark
added
accepted
ilyavolodin
approved these changes
Feb 8, 2017
|
Thanks for contributing! |
This was referenced Feb 20, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
As outlined in #7977, autofixing is not performed when:
Booleanis called with more than one argument.Booleanis called with a spread element as the first argument.And
!Boolean()now autofixed totrue.Is there anything you'd like reviewers to focus on?
I'm a bit unsure if the autofixing logic for
!Boolean()is solid enough, an extra set of eyes is appreciated!