New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: fix a typo in Shareable Configs documentation #8036
Conversation
@no23reason, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @Akkuma and @icyflame to be potential reviewers. |
Thanks for the pull request, @no23reason! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
There was a typo in the phrase "read from a file".
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for contributing!
Don't worry about the commit message- we can fix that on merge. Thanks again!
Ah, thanks for fixing the commit message anyway. :-) |
No problem, it was my bad :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for contributing to ESLint!
What is the purpose of this pull request? (put an "X" next to item)
[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
There is a typo in the phrase "read from a file".
Is there anything you'd like reviewers to focus on?
No