Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix a typo in Shareable Configs documentation #8036

Merged
merged 1 commit into from Feb 7, 2017

Conversation

no23reason
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
There is a typo in the phrase "read from a file".

Is there anything you'd like reviewers to focus on?
No

@mention-bot
Copy link

@no23reason, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @Akkuma and @icyflame to be potential reviewers.

@jsf-clabot
Copy link

jsf-clabot commented Feb 7, 2017

CLA assistant check
All committers have signed the CLA.

@eslintbot
Copy link

Thanks for the pull request, @no23reason! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

There was a typo in the phrase "read from a file".
@eslintbot
Copy link

LGTM

@no23reason no23reason changed the title Fix a typo in Shareable Configs documentation Docs: fix a typo in Shareable Configs documentation Feb 7, 2017
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

Don't worry about the commit message- we can fix that on merge. Thanks again!

@platinumazure
Copy link
Member

Ah, thanks for fixing the commit message anyway. :-)

@no23reason
Copy link
Contributor Author

No problem, it was my bad :)

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing to ESLint!

@kaicataldo kaicataldo merged commit a11d4a6 into eslint:master Feb 7, 2017
@no23reason no23reason deleted the patch-1 branch February 7, 2017 16:32
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants