Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Espree v3.4.0 #8019

Merged
merged 1 commit into from Feb 2, 2017
Merged

Upgrade: Espree v3.4.0 #8019

merged 1 commit into from Feb 2, 2017

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Feb 2, 2017

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

Dependency version bump

What changes did you make? (Give an overview)
Ensure the minimum version of Espree is v3.4.0. Acorn v4.0.5 is currently causing some issues, and we had to lock the version in Espree to v4.0.4.

Relevant issues:

Is there anything you'd like reviewers to focus on?
Nothing in particular!

@mention-bot
Copy link

@kaicataldo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gajus, @nzakas and @alberto to be potential reviewers.

Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Should this commit have the Upgrade: prefix?

@mikesherov
Copy link
Contributor

👍

@kaicataldo kaicataldo changed the title Build: Espree v3.4.0 Upgrade: Espree v3.4.0 Feb 2, 2017
@eslintbot
Copy link

LGTM

@alberto alberto merged commit 99d386d into master Feb 2, 2017
@ilyavolodin ilyavolodin deleted the espree-update branch February 2, 2017 23:47
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants