Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in object-curly-newline.md #8002

Merged
merged 1 commit into from Jan 31, 2017
Merged

Fix typo in object-curly-newline.md #8002

merged 1 commit into from Jan 31, 2017

Conversation

danny-andrews
Copy link
Contributor

It looks like the curly braces got turned into square brackets between the incorrect and correct code examples.

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update

What changes did you make? (Give an overview)

See commit message.

It looks like the curly braces got turned into square brackets between the incorrect and correct code examples.
@mention-bot
Copy link

@danny-andrews, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mysticatea, @scriptdaemon and @alberto to be potential reviewers.

@eslintbot
Copy link

Thanks for the pull request, @danny-andrews! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

Copy link
Member

@gyandeeps gyandeeps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update the commit message

Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@not-an-aardvark not-an-aardvark merged commit f2be7e3 into eslint:master Jan 31, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants