Chore: enable no-else-return on ESLint codebase #7986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
platinumazure
approved these changes
Jan 27, 2017
vitorbal
suggested changes
Jan 27, 2017
| @@ -628,15 +628,15 @@ module.exports = { | |||
| } | |||
| }; | |||
|
|
|||
| } else { // Obey beforeColon and afterColon in each property as configured | |||
| } // Obey beforeColon and afterColon in each property as configured | |||
There was a problem hiding this comment.
Should this comment go in a separate line now?
gyandeeps
approved these changes
Jan 27, 2017
|
LGTM |
vitorbal
approved these changes
Jan 28, 2017
vitorbal
added a commit
that referenced
this pull request
Jan 28, 2017
gyandeeps
pushed a commit
that referenced
this pull request
Jan 28, 2017
This was referenced Feb 3, 2017
This was referenced Feb 5, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This enables
no-else-returnon the ESLint codebase for dogfooding now that it's autofixable.The changes in this PR were made with the new autofixer.
Is there anything you'd like reviewers to focus on?
Nothing in particular