Fix: brace-style false positive for keyword method names (fixes #7974) #7980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @vitorbal and @BYK to be potential reviewers. |
not-an-aardvark
added
accepted
ilyavolodin
approved these changes
Jan 25, 2017
kaicataldo
approved these changes
Jan 25, 2017
gyandeeps
approved these changes
Jan 25, 2017
btmills
approved these changes
Jan 25, 2017
This was referenced Jan 25, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix (see #7974)
What changes did you make? (Give an overview)
This updates
brace-styleto use node-specific checks for braces next tocatch,finally, andelsekeywords. Previously, the rule would simply detect anycatch,finally, orelsekeyword that followed a closing curly brace, but that had a false positive if these keywords were used as class method names.Is there anything you'd like reviewers to focus on?
Nothing in particular