Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: ensure operator-assignment handles exponentiation operators #7970

Merged
merged 1 commit into from Jan 27, 2017

Conversation

not-an-aardvark
Copy link
Member

@not-an-aardvark not-an-aardvark commented Jan 24, 2017

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

Tell us about your environment

  • ESLint Version: master
  • Node Version: 7.4.0
  • npm Version: 4.0.5

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

rules:
  operator-assignment: error
parserOptions:
  ecmaVersion: 7

What did you do? Please include the actual source code causing the issue.

foo = foo ** bar;

What did you expect to happen?

I expected an error to be reported, suggesting that the code use a compound operator.

What actually happened? Please include the actual, raw output from ESLint.

No error was reported.

What changes did you make? (Give an overview)

This updates operator-assignment to identify that the ** operator can be replaced with a compound operator.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules labels Jan 24, 2017
@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vitorbal, @btmills and @nzakas to be potential reviewers.

@eslintbot
Copy link

LGTM

@not-an-aardvark not-an-aardvark merged commit fbd7c13 into master Jan 27, 2017
@not-an-aardvark not-an-aardvark deleted the operator-assignment-exponents branch January 27, 2017 02:30
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants