Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: typo in prefer-promise-reject-errors #7958

Merged
merged 1 commit into from Jan 20, 2017

Conversation

pmcelhaney
Copy link
Contributor

@pmcelhaney pmcelhaney commented Jan 20, 2017

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

"It is considered good practice to only pass instances of the built-in Error object to the reject() function"

Is there anything you'd like reviewers to focus on?

Nope. Just a typo. And four extra words for clarity.

@eslintbot
Copy link

LGTM

@jsf-clabot
Copy link

jsf-clabot commented Jan 20, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. LGTM

@not-an-aardvark not-an-aardvark merged commit 8bcbf5d into eslint:master Jan 20, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants