Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: add "variables" option to no-use-before-define (fixes #7111) #7948

Merged
merged 2 commits into from Jan 27, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Changes an existing rule (see #7111)

What changes did you make? (Give an overview)

This adds a variables option to no-use-before-define rule. When the option is set to false, the rule allows variables to be used before they are defined if the declaration is in an upper scope.

Is there anything you'd like reviewers to focus on?

I'm concerned that there might be edge-cases that I didn't account for in the tests. It would be useful to double-check the tests and double-check that there aren't any special cases where this logic will work incorrectly.

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules labels Jan 20, 2017
@eslintbot
Copy link

LGTM

@not-an-aardvark not-an-aardvark merged commit c5066ce into master Jan 27, 2017
@not-an-aardvark not-an-aardvark deleted the no-use-before-define-variables branch January 27, 2017 02:29
@feross
Copy link
Contributor

feross commented Jan 27, 2017

👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants