Chore: update to use ES6 classes (refs #7849) #7891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@qlaire, thanks for your PR! By analyzing the history of the files in this pull request, we identified @IanVS, @mysticatea and @nzakas to be potential reviewers. |
|
LGTM |
16 tasks
gyandeeps
reviewed
Jan 10, 2017
|
|
||
| RuleFixer.prototype = { | ||
| constructor: RuleFixer, | ||
| const ruleFixer = { |
There was a problem hiding this comment.
We might want to freeze this object so that we are consistent with what we had previously.
kaicataldo
reviewed
Jan 10, 2017
|
|
||
| constructor: Registry, | ||
| /** | ||
| * @param {rulesConfig} [rulesConfig] Hash of rule names and arrays of possible configurations |
There was a problem hiding this comment.
Nitpick: Can we get rid of the extra whitespace after @param?
|
LGTM |
|
@gyandeeps @kaicataldo thanks so much for reviewing! I've made the two changes you suggested. |
gyandeeps
added
accepted
gyandeeps
approved these changes
Jan 10, 2017
kaicataldo
approved these changes
Jan 10, 2017
|
Leaving this open a little bit longer so that we can get a few more pairs of eyes on this. |
ilyavolodin
approved these changes
Jan 11, 2017
|
LGTM. Thanks for contributing! |
This was referenced Jan 20, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ x ] Other, please explain:
What changes did you make? (Give an overview)
Update constructor functions to use ES6 classes. Also, changed one constructor function (rule-fixer.js) to a plain object since it does not have any internal state.
Is there anything you'd like reviewers to focus on?