Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: clarify the default behavior of operator-linebreak (fixes #7459) #7726

Merged
merged 1 commit into from Dec 9, 2016

Conversation

not-an-aardvark
Copy link
Member

@not-an-aardvark not-an-aardvark commented Dec 8, 2016

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

The default behavior for operator-linebreak is to use the "after" option with overrides for the ? and : operators. However, the documentation incorrectly implied that the overrides were always present when using the "after" option, which is not the case. The overrides are part of the default configuration, but they aren't related to the "after" option.

(fixes #7459)

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@not-an-aardvark not-an-aardvark added the documentation Relates to ESLint's documentation label Dec 8, 2016
@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @scriptdaemon, @BenoitZugmeyer and @BYK to be potential reviewers.

@eslintbot
Copy link

LGTM

@not-an-aardvark not-an-aardvark merged commit 4742d82 into master Dec 9, 2016
@not-an-aardvark not-an-aardvark deleted the operator-linebreak-docs branch December 9, 2016 01:24
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator-Linebreak Default Option Behaves Differently When Option Is Actually Specified
5 participants