Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove incorrect info about issue requirements from PR guide #7691

Merged
merged 1 commit into from Dec 4, 2016

Conversation

not-an-aardvark
Copy link
Member

@not-an-aardvark not-an-aardvark commented Dec 4, 2016

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

As pointed out in #7589 (comment), our pull request guide incorrectly states that an issue is required for all non-documentation changes. This removes the reference to that requirement.

Is there anything you'd like reviewers to focus on?

We already mention needing an issue for core/breaking changes in "Getting Started", so I think we can just remove the reference here.

@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas to be a potential reviewer.

@not-an-aardvark not-an-aardvark added the documentation Relates to ESLint's documentation label Dec 4, 2016
@eslintbot
Copy link

LGTM

@not-an-aardvark not-an-aardvark merged commit 90a5d29 into master Dec 4, 2016
@not-an-aardvark not-an-aardvark deleted the no-issue branch December 4, 2016 04:00
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants