New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test output even if errors is just a number #7640
Conversation
|
@ForbesLindesay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @mysticatea and @platinumazure to be potential reviewers. |
Thanks for the pull request, @ForbesLindesay! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a unit test for this change.
@ForbesLindesay can you please go back and fill in the PR template we have setup? The extra context helps. |
No, my previous experience of contributing to eslint has been terrible. Going through the process proved a waste of everyone's time. I am providing this code under the WTF public license. Please feel free to do whatever you like with it. I provide it meerly to be a good open source citizen. |
I'm sorry you had a bad experience contributing in the past. Unfortunately, we can't do anything with a pull request that hasn't followed our contributor guidelines. In the future, if you feel that you'd like to let us know about a problem, please open an issue instead. |
Opened #7657 for further tracking. |
If the
errors
field is just a number, then ESLint is currently ignoring theoutput
field. This makes it easy to accidentally not test the output of a rule's auto-fix.