Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test output even if errors is just a number #7640

Closed
wants to merge 1 commit into from
Closed

Test output even if errors is just a number #7640

wants to merge 1 commit into from

Conversation

ForbesLindesay
Copy link

If the errors field is just a number, then ESLint is currently ignoring the output field. This makes it easy to accidentally not test the output of a rule's auto-fix.

@jsf-clabot
Copy link

jsf-clabot commented Nov 23, 2016

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@mention-bot
Copy link

@ForbesLindesay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @mysticatea and @platinumazure to be potential reviewers.

@eslintbot
Copy link

Thanks for the pull request, @ForbesLindesay! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test for this change.

@nzakas
Copy link
Member

nzakas commented Nov 23, 2016

@ForbesLindesay can you please go back and fill in the PR template we have setup? The extra context helps.

@ForbesLindesay
Copy link
Author

No, my previous experience of contributing to eslint has been terrible. Going through the process proved a waste of everyone's time.

I am providing this code under the WTF public license. Please feel free to do whatever you like with it. I provide it meerly to be a good open source citizen.

@nzakas
Copy link
Member

nzakas commented Nov 25, 2016

I'm sorry you had a bad experience contributing in the past. Unfortunately, we can't do anything with a pull request that hasn't followed our contributor guidelines. In the future, if you feel that you'd like to let us know about a problem, please open an issue instead.

@nzakas
Copy link
Member

nzakas commented Nov 25, 2016

Opened #7657 for further tracking.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants