Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Update markdownlint dependency to 0.3.1 (fixes #7589) #7592

Merged
merged 1 commit into from Nov 16, 2016
Merged

Upgrade: Update markdownlint dependency to 0.3.1 (fixes #7589) #7592

merged 1 commit into from Nov 16, 2016

Conversation

DavidAnson
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

Updating a devDependency in package.json.

What changes did you make? (Give an overview)

Updated markdownlint dependency to 0.3.1, enabled resultVersion 1 for more detailed reporting.

Is there anything you'd like reviewers to focus on?

No

@jsf-clabot
Copy link

jsf-clabot commented Nov 13, 2016

CLA assistant check
All committers have signed the CLA.

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@DavidAnson, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kaicataldo, @nzakas and @mysticatea to be potential reviewers.

Copy link
Member

@ilyavolodin ilyavolodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion build This change relates to ESLint's build process labels Nov 14, 2016
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just waiting another day so others can take a look.

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@vitorbal
Copy link
Member

Thanks, @DavidAnson!

@ilyavolodin ilyavolodin merged commit d90ca46 into eslint:master Nov 16, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion build This change relates to ESLint's build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants