Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Relax permission for merging PRs (refs eslint/tsc-meetings#20) #7360

Merged
merged 1 commit into from Oct 14, 2016

Conversation

btmills
Copy link
Member

@btmills btmills commented Oct 14, 2016

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Please check each item to ensure your pull request is ready:

  • I've read the pull request guide
  • n/a I've included tests for my change
  • I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)

Following today's TSC meeting, added a note that committers may merge any PR that has been approved by a TSC member.

Is there anything you'd like reviewers to focus on?

The previous requirements for merging a PR without explicit TSC member approval haven't changed?

@mention-bot
Copy link

@btmills, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas to be a potential reviewer.

@eslintbot
Copy link

LGTM

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitorbal vitorbal added the documentation Relates to ESLint's documentation label Oct 14, 2016
@vitorbal vitorbal merged commit 19d2996 into master Oct 14, 2016
@btmills btmills deleted the who-can-merge branch December 12, 2016 18:50
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants