Docs: Adding missing ES8 reference to configuring #7271
Conversation
|
LGTM |
|
@platinumazure, thanks for your PR! By analyzing the annotation information on this pull request, we identified @btmills, @nzakas and @pedrottimark to be potential reviewers |
| @@ -15,7 +15,7 @@ All of these options give you fine-grained control over how ESLint treats your c | |||
|
|
|||
| ## Specifying Parser Options | |||
|
|
|||
| ESLint allows you to specify the JavaScript language options you want to support. By default, ESLint supports only ECMAScript 5 syntax. You can override that setting to enable support for ECMAScript 6 and 7 as well as [JSX](http://facebook.github.io/jsx/) by using parser options. | |||
| ESLint allows you to specify the JavaScript language options you want to support. By default, ESLint supports only ECMAScript 5 syntax. You can override that setting to enable support for ECMAScript 6/7/8 as well as [JSX](http://facebook.github.io/jsx/) by using parser options. | |||
There was a problem hiding this comment.
We should use the year for ES8 (ES2017), as no one calls it ES8.
There was a problem hiding this comment.
Since this is prose, not code, should I also say ES2015/ES2016 as well for consistency? Or should I say specifically 6, 7, ES2017?
There was a problem hiding this comment.
Maybe You can override that setting to enable support for ECMAScript 6, 7, and 2017 as well as JSX?
There was a problem hiding this comment.
Maybe something that won't require update in the future:
By default, ESLint expects ECMAScript 5 syntax. You can override that setting to enable support for other ECMAScript versions as well as JSX by using parser options.
There was a problem hiding this comment.
I'll go with @nzakas' suggestion. We definitely don't need to list supported ecmaVersion values twice.
|
LGTM |
|
@nzakas I've updated, let me know if I can change anything else. |
eslint-deprecated
bot
added
the
archived due to age
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Please check each item to ensure your pull request is ready:
What changes did you make? (Give an overview)
"Parser options" section in "configuring" doc has an intro paragraph that alludes to using JSX or enabling ES6/ES7 via parser options. I've added ES2017 ("8") to that paragraph.
Is there anything you'd like reviewers to focus on?
Nothing in particular.