Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Ensure indent handles nested functions correctly (fixes #7249) #7265

Merged
merged 1 commit into from Sep 30, 2016

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

See #7249

Please check each item to ensure your pull request is ready:

  • I've read the pull request guide
  • I've included tests for my change
  • (n/a) I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)

This ensures that indent handles the parameters of nested function declarations and function expressions correctly. Previously, it was not accounting for the initial offset of a function, so it would always require the same parameter indent regardless of whether the function itself was indented.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@eslintbot
Copy link

LGTM

@RecuencoJones
Copy link

LGTM

@vitorbal vitorbal added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Sep 30, 2016
@vitorbal
Copy link
Member

@not-an-aardvark looks like there are some conflicts in the test file. Could you do a rebase?

@not-an-aardvark
Copy link
Member Author

not-an-aardvark commented Sep 30, 2016

I won't have a chance to rebase this until later today. If it's important that we get this change into today's release, feel free to rebase and push to my branch.

edit: Never mind, I ended up having time to rebase.

@eslintbot
Copy link

LGTM

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzakas nzakas merged commit 332d213 into eslint:master Sep 30, 2016
@not-an-aardvark not-an-aardvark deleted the nested-indent-7249 branch September 30, 2016 18:06
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants